Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove slow query #1586

Merged
merged 2 commits into from
Oct 6, 2023
Merged

remove slow query #1586

merged 2 commits into from
Oct 6, 2023

Conversation

tudor-malene
Copy link
Collaborator

Why this change is needed

remove the slow "FetchHeadBatch" query from everywhere, except startup

@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 13:24 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 13:31 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 13:31 — with GitHub Actions Inactive
@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 13:33 — with GitHub Actions Inactive
Copy link
Contributor

@StefanIliev545 StefanIliev545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we probably need to refactor it somehow so that the head batch caching is contained in the storage and fetchHeadBatch does FetchBatchBySeqNo directly to avoid future mistakes

@tudor-malene tudor-malene temporarily deployed to sepolia-testnet October 6, 2023 13:39 — with GitHub Actions Inactive
@tudor-malene tudor-malene merged commit 30494ec into main Oct 6, 2023
2 checks passed
@tudor-malene tudor-malene deleted the tudor/remove_slow_query branch October 6, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants